search

hadiyarajesh / note-x

Notes and Reminders on steroid
Apache License 2.0
11 stars 10 forks source link

Added CODEOWNERS files. #19

Closed sumanabhi closed 2 years ago

sumanabhi commented 2 years ago

This PR is going to add the CODEOWNERS file for this repo.

Fixes #32

sumanabhi commented 2 years ago

So, is it something like below?

  1. Every user is codeowner of their respective branch
  2. What about review request? How are we going to automatically request review?
  3. What changes needs to be done to support it?

Yeah @hadiyarajesh, Almost similar to this I have written to achieve it.

  1. Not everyone than Just the members who are included in @NoteXCommunity/code-reviewer
  2. I have written to support all the changes but if this will not work we are having some options in the Repository Settings as well. if this does not work then we can look into that as well.
hadiyarajesh commented 2 years ago

Can i merge now? Asking coz of don't-merge label

sumanabhi commented 2 years ago

Can i merge now? Asking coz of don't-merge label

No, there are some branch not available till yesterday. Today will complete this.

Now we can go merge this.

hadiyarajesh commented 2 years ago

I like to address 2 things

  1. Swapnil is not team lead, siddu patil is.
  2. Loveleen is supposed to change her branch from loveleen_dev to branch_loveleen. @loveleenkaurnancy have you made the changes?
hadiyarajesh commented 2 years ago

I can see she did the changes. @sumanabhi can you please change both issues and then we're good to merge.