search

hadley / emo

Easily insert emoji into R and RMarkdown
416 stars 53 forks source link

Add ji_fisher() as 🙏 to Carrie Fisher (closes #22) #23

Closed LucyMcGowan closed 7 years ago

romainfrancois commented 7 years ago

perhaps we can just leave fisher_lst unexported, i.e. maybe it does not need its own file in data/

I don't think it would be a big deal to move the content of data-raw/fisher.R to emojis.R so that we would spare the file in data/ and just use one use_data( internal = TRUE) call without the saveand load dance.

Also, not sure why it shows changes in the json file, as I don't think you use it for this PR.

LucyMcGowan commented 7 years ago

I couldn't find a way to use devtools::use_data() in two separate files (both emoji.R and fisher.R) with internal = TRUE, since it would have to also include overwrite = TRUE and it would overwrite the sysdata.rda created by the other (which is why I do the saving/loading dance 💃). Do you know how to go about that? The .json file was recreated because I reran emoji.R and it turned out there were a few updates to the document it pulled from.

romainfrancois commented 7 years ago

I actually did not know about overwrite=FALSE before I look at this repo 🙊.

Alternatively maybe we could export it, it might make sense to view the alphabet anyway, so doing a use_data( fisher_lst, overwrite = TRUE )

LucyMcGowan commented 7 years ago

👌 do you have a different name that you'd prefer other than fisher_lst if we're exporting?

romainfrancois commented 7 years ago

Can't think of anything that ✔️, we can always change it later.