search

hadley / emo

Easily insert emoji into R and RMarkdown
416 stars 53 forks source link

Submodules means that install_github doesn't work #36

Closed hadley closed 6 years ago

hadley commented 6 years ago

And hence adv-r is now failing to build 😢

hadley commented 6 years ago

Hmmm, the submodules are only in data-raw which shouldn't cause problems.

I think maybe the data source has changed? The main problem is that emo::ji("dark_sunglasses") no longer works for me.

romainfrancois commented 6 years ago

I only use the submodules for data-raw.

This was only supposed to use more data sources. I’ll have a look at why this alias no longer works.

romainfrancois commented 6 years ago

dark_sunglasses are back

> emo::ji("dark_sunglasses")
🕶

should I remove the submodules ? We only really need this when we update the data ? @hadley

romainfrancois commented 6 years ago

This was because the dark sunglasses emoji is not "fully qualified" so was filtered out in the data. Side effect is now I need to find a way to update the regex to cover non fully qualified emojis. #41

hadley commented 6 years ago

Submodules are fine for the raw data