hadley / ggplot2-book

ggplot2: elegant graphics for data analysis
https://ggplot2-book.org/
1.57k stars 684 forks source link

Saving plots to .rds files #344

Closed teunbrand closed 1 year ago

teunbrand commented 1 year ago

The advice given in this section of the book:

https://github.com/hadley/ggplot2-book/blob/bf758abd4270b60d4ceb4e7f3d3bec73193526fa/getting-started.Rmd#L526-L533

Is being called a 'flawed workflow' in https://github.com/tidyverse/ggplot2/issues/3994#issuecomment-642051735 and complicates between-version compatability as mentioned here: https://github.com/tidyverse/ggplot2/issues/3994#issuecomment-1142116587. I think it might be best to omit this advice altogether.

hadley commented 1 year ago

Oh yeah, that's definitely a DON'T DO.

djnavarro commented 1 year ago

ooh, yeah, I'll fix that one now!

teunbrand commented 1 year ago

Thanks!