search

hadley / ggplot2-book

ggplot2: elegant graphics for data analysis
https://ggplot2-book.org/
1.55k stars 678 forks source link

spring case study chapter #360

Closed djnavarro closed 1 year ago

djnavarro commented 1 year ago

I think this is now ready for review: the majority of the changes are minor rewrites and scaffolding: basically just going through the ideas a little more slowly so that it's a little easier on folks new to ggplot2 extensions.

The main structural change is that the "grid in 5 minutes" subsection has been promoted to a section called "an introduction to grid", and it's a little more detailed than the original version. I think that's probably necessary if we want readers to be able to follow the jump from "pure" ggproto to ggplot2 extensions that define custom grobs.

As always, any comments appreciated! :)

hadley commented 1 year ago

After we merge this (and review the other PRs) we should usethis::git_default_branch_rename() to switch the default from "master" to "main".

hadley commented 1 year ago

I just pushed some minor tweaks including just a couple of comments. It's looking great and you should feel free to merge it once your read/respond to my comments.

hadley commented 1 year ago

I’ll do the master -> main switch momentarily so you’ll need to update you default branch when you next work on this.