hadley / ggplot2-book

ggplot2: elegant graphics for data analysis
https://ggplot2-book.org/
1.57k stars 683 forks source link

Port from bookdown to quarto #365

Closed djnavarro closed 1 year ago

djnavarro commented 1 year ago

Substantive changes

Other changes

Something confusing

Proposed next steps

djnavarro commented 1 year ago

@hadley okay we have a minimum viable PR (is MVPR an accepted term?) to switch to quarto. As always there are some rough edges. The most noticeable is that the switch from the bespoke columns() function to the quarto layouts chunk option has left us with a lot of plots that need some love on the aspect ratio and size front. There's also a really fkn bizarre quarto bug(?) I had to work around (see above) to make the bloody thing build, but despite its weirdness from a quarto pov it's trivial from the ggplot2 book pov. And of course (as always) there's a lot of smoothing I want to do later but this version works pretty well and I think it's probably wise to merge the MVPR before making a start on the sweet sugary polishes 😀