hadley / mastering-shiny

Mastering Shiny: a book
https://mastering-shiny.org/
Other
1.34k stars 566 forks source link

Read data in Chapter 4 #595

Closed benjamin-coppel closed 1 month ago

benjamin-coppel commented 1 year ago

When you want to download NEISS data, the url of the repo doesn´t work.

I think that the url was update.

You need to put this url in order to fix the download function

download <- function(name){ url <- "https://github.com/hadley/mastering-shiny/tree/master/neiss/" download.file(paste0(url, name), paste0("neiss/", name), quiet = TRUE) }

benjamin-coppel commented 1 year ago

For some reason, when I download the data using the function and then read it, the data looks so weird.

I have to download manually

nmolanog commented 1 year ago

For some reason, when I download the data using the function and then read it, the data looks so weird.

I have to download manually

I have the same issue

carehu commented 1 year ago

I have

For some reason, when I download the data using the function and then read it, the data looks so weird. I have to download manually

I have the same issue

I have the same issue. Did you find a solution? when I run the code the data doesn't look like what is the book

This is what I get (my folder path is different but I think that shouldn't be an issue) image

This is what is in the book injuries <- vroom::vroom("neiss/injuries.tsv.gz") injuries

> # A tibble: 255,064 × 10

> trmt_date age sex race bodypart diag locat…¹ prod…² weight narra…³

>

> 1 2017-01-01 71 male white Upper Trunk Contus… Other … 1807 77.7 71YOM …

> 2 2017-01-01 16 male white Lower Arm Burns,… Home 676 77.7 16YOM …

> 3 2017-01-01 58 male white Upper Trunk Contus… Home 649 77.7 58 YOM…

> 4 2017-01-01 21 male white Lower Trunk Strain… Home 4076 77.7 21 YOM…

> 5 2017-01-01 54 male white Head Inter … Other … 1807 77.7 54 YOM…

> 6 2017-01-01 21 male white Hand Fractu… Home 1884 77.7 21 YOM…

> # … with 255,058 more rows, and abbreviated variable names ¹​location,

> # ²​prod_code, ³​narrative

benjamin-coppel commented 1 year ago

@carehu My "non-fancy" solution was download manually the files, put them in a folder and then read the data from this new folder in order to follow the example in the book.

carehu commented 1 year ago

@carehu My "non-fancy" solution was download manually the files, put them in a folder and then read the data from this new folder in order to follow the example in the book.

Thank you! For products & population data I did like you explained and is working. But for the injuries data it still doesn't work. I have used the R.utils package to unzip the file and if I open the unzipped file in notepad it doesn't look like what is in the book. For now I think I will just skip the examples in this chapter. Thanks.

library(R.utils) gunzip("neiss/injuries.tsv.gz", remove=FALSE)

hadley commented 1 month ago

Fixed now 😄