hadley / mastering-shiny

Mastering Shiny: a book
https://mastering-shiny.org/
Other
1.33k stars 566 forks source link

Chapter 7.3 - images not displayed when code ran #602

Open Mkranj opened 1 year ago

Mkranj commented 1 year ago

Description

Copy-pasting the code in 7.3 leads to an app where the frame where the image should be is empty. The links to the images work, although the ones for authors don't.

Probable cause

src = file.path("puppy-photos", paste0(input$id, ".jpg")), "puppy-photos" doesn't seem to be a valid link. Perhaps this refers to images stored on a local computer.

Potential fix

Update the link in the code above to a link to unsplash.com, according to image id.

ArthurDentDK commented 1 year ago

It would be cool to point directly at the URL! Unfortunately, the jpg files have different names (author-id-unsplash.jpg) online and the URL in Hadley's example only points to redirects.

Downloading the images and renaming them to match the code works, but is of course not as elegant.