search

hadley / r-pkgs

Building R packages
https://r-pkgs.org
Other
869 stars 631 forks source link

fix typos #1007

Closed spaette closed 1 year ago

spaette commented 1 year ago

Closes https://github.com/hadley/r-pkgs/issues/997

code.Rmd dependencies-in-practice.Rmd description.Rmd lifecycle.Rmd package-within.Rmd whole-game.Rmd

spaette commented 1 year ago

@jennybc

Would you be OK with going ahead and merging this.

jennybc commented 1 year ago

No I can't/won't. In many cases you are making changes in, e.g. code comments that are copied verbatim from an actual package or just comments that are a note-to-self for the book authors. So this PR is a mix of a very few things that are only marginally helpful, from the perspective of this book, and other changes that are not.

I know this is well-intentioned but these PRs that seem to consist of just running a spell checker over the book files, without actually engaging with what the material is for, really aren't helpful.