search

hadley / r-pkgs

Building R packages
https://r-pkgs.org
Other
866 stars 631 forks source link

Update lifecycle.Rmd #1038

Closed MikeJohnPage closed 9 months ago

MikeJohnPage commented 9 months ago

In section 21.2 it states that the function package_version() comes from utils, but I think this is a mistake and is supposed to say that it comes from base.

I've updated the sections of relevant text to reflect this, but now I am not sure the updated footnote indicating that base should be added to imports (previously it said utils should be added) is relevant/required.

jennybc commented 9 months ago

Wow, I'm not sure how I did this! At first I thought maybe package_version() moved from utils to base?!? But of course it has not. In any case, thanks for the catch.

(Confusingly, there is utils::packageVersion() but that's not what I'm talking about in this section of the book.)

Yeah, the proposed fix isn't quite right yet, because package_version()'s presence in base, as opposed to utils, negates most of what's being said. Now that I've confirmed your hunch, you can take another crack. Or next time I come through I'll do it.

MikeJohnPage commented 9 months ago

(Confusingly, there is utils::packageVersion() but that's not what I'm talking about in this section of the book.)

Yes, this stumped me too. For a while I was convinced it was just a mistake of using snake_case instead of camelCase, but then I clicked they are different functions!

It should be okay to merge now I think. Thanks.

MikeJohnPage commented 9 months ago

Also, this book is great, so thanks for all your hard work on it - it is appreciated 👏