search

hadley / r4ds

R for data science: a book
http://r4ds.hadley.nz
Other
4.52k stars 4.19k forks source link

19.5.1 Cross joins #1569

Closed jcornickm closed 10 months ago

jcornickm commented 1 year ago

The text before and the caption of figure 20.14 describe a cross join between x and y, but the illustration itself shows a cross join between x and itself. It is a small detail, but it might be confusing

mine-cetinkaya-rundel commented 10 months ago

@hadley Should we update the image or the caption and text? Latter is easier but does seem odd to join something with itself. It's at https://r4ds.hadley.nz/joins#cross-joins.

image

jcornickm commented 10 months ago

So it seems you have answered your own question! It blows my mind that you, not somebody's assistant's assistant would answer something like this. Thanks!

Get Outlook for iOShttps://aka.ms/o0ukef

From: Mine Cetinkaya-Rundel @.> Sent: Thursday, November 9, 2023 9:36:25 AM To: hadley/r4ds @.> Cc: Jorge Cornick @.>; Author @.> Subject: Re: [hadley/r4ds] 20.5.1 Cross joins (Issue #1569)

@hadleyhttps://github.com/hadley Should we update the image or the caption and text? Latter is easier but does seem odd to join something with itself.

[image]https://user-images.githubusercontent.com/5965649/281785094-7d1bb60f-491d-496f-a6aa-814dc3514b99.png

— Reply to this email directly, view it on GitHubhttps://github.com/hadley/r4ds/issues/1569#issuecomment-1804062397, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATZRKMBME5EONSEQ4UI4VLTYDTZ7TAVCNFSM6AAAAAA35UNK6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGA3DEMZZG4. You are receiving this because you authored the thread.Message ID: @.***>

hadley commented 10 months ago

I think it's ok to leave it as is; it's pretty common to do self-cross-joins and the main takeaway from the diagram is that every cell has a dot in it.

jcornickm commented 10 months ago

It is your book!

Get Outlook for iOShttps://aka.ms/o0ukef

From: Hadley Wickham @.> Sent: Thursday, November 9, 2023 11:51:39 AM To: hadley/r4ds @.> Cc: Jorge Cornick @.>; Author @.> Subject: Re: [hadley/r4ds] 19.5.1 Cross joins (Issue #1569)

I think it's ok to leave it as is; it's pretty common to do self-cross-joins and the main takeaway from the diagram is that every cell has a dot in it.

— Reply to this email directly, view it on GitHubhttps://github.com/hadley/r4ds/issues/1569#issuecomment-1804290533, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATZRKMAOXXW56JVEQXDWIQDYDUJ2XAVCNFSM6AAAAAA35UNK6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGI4TANJTGM. You are receiving this because you authored the thread.Message ID: @.***>