search

hadley / strict

Make R a little bit stricter
235 stars 10 forks source link

Use of deprecated function `rlang::env_bind_fns()` #38

Open michaelmhoffman opened 5 years ago

michaelmhoffman commented 5 years ago 
> library(strict)
Warning message:
`env_bind_fns()` is deprecated as of rlang 0.3.0.
Please use `env_bind_active()` instead.
This warning is displayed once per session. 
> library(sessioninfo)
> session_info()
─ Session info ───────────────────────────────────────────────────────────────
 setting  value                       
 version  R version 3.4.4 (2018-03-15)
 os       Ubuntu 18.04.3 LTS          
 system   x86_64, linux-gnu           
 ui       X11                         
 language en_CA:en                    
 collate  en_US.UTF-8                 
 ctype    en_US.UTF-8                 
 tz       America/Toronto             
 date     2019-09-24                  

─ Packages ───────────────────────────────────────────────────────────────────
 package     * version    date       lib source                        
 assertthat    0.2.1      2019-03-21 [1] CRAN (R 3.4.4)                
 cli           1.1.0      2019-03-19 [1] CRAN (R 3.4.4)                
 crayon        1.3.4      2017-09-16 [1] CRAN (R 3.4.4)                
 rlang         0.4.0      2019-06-25 [1] CRAN (R 3.4.4)                
 sessioninfo * 1.1.1      2018-11-05 [1] CRAN (R 3.4.4)                
 strict      * 0.0.0.9000 2019-04-01 [1] Github (hadley/strict@446573b)
 withr         2.1.2      2018-03-15 [1] CRAN (R 3.4.4)                

[1] /usr/local/lib/R/site-library
[2] /usr/lib/R/site-library
[3] /usr/lib/R/library
torfason commented 4 years ago

I can confirm that applying the fix above, from karldw, removed the warning on my local machine and has not caused any other issues to pop up:

remotes::install_github("karldw/strict",ref="bugfix-38")

michaelmhoffman commented 2 years ago

Now that env_bind_fns() is gone, not just deprecated, I can't install strict at all from the upstream. remotes::install_github("karldw/strict", ref = "bugfix-38") seems to work.

> devtools::install_github("hadley/strict")
Downloading GitHub repo hadley/strict@HEAD
✔  checking for file ‘/tmp/Rtmpa1MSLA/remotesa023523b7e1a0/hadley-strict-446573b/DESCRIPTION’ ...
─  preparing ‘strict’:
✔  checking DESCRIPTION meta-information ...
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
   Omitted ‘LazyData’ from DESCRIPTION
─  building ‘strict_0.0.0.9000.tar.gz’

Installing package into ‘/home/mhoffman/R/x86_64-pc-linux-gnu-library/4.1’
(as ‘lib’ is unspecified)
* installing *source* package ‘strict’ ...
** using staged installation
** R
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
Error: package or namespace load failed for ‘strict’:
 .onAttach failed in attachNamespace() for 'strict', details:
  call: env_bind_fns(env, T = function() strict_abort("Please use TRUE, not T"), 
  error: could not find function "env_bind_fns"
Error: loading failed
Execution halted
ERROR: loading failed
* removing ‘/home/mhoffman/R/x86_64-pc-linux-gnu-library/4.1/strict’
Warning message:
In i.p(...) :
  installation of package ‘/tmp/Rtmpa1MSLA/filea02357bf2f35b/strict_0.0.0.9000.tar.gz’ had non-zero exit status
> library(sessioninfo)
> session_info()
─ Session info ────────────────────────────────────────────────────────────────────────────────────────
 setting  value
 version  R version 4.1.2 (2021-11-01)
 os       Ubuntu 22.04.1 LTS
 system   x86_64, linux-gnu
 ui       X11
 language en_US:en
 collate  en_US.UTF-8
 ctype    en_US.UTF-8
 tz       America/Toronto
 date     2022-08-22
 pandoc   2.9.2.1 @ /bin/pandoc

─ Packages ────────────────────────────────────────────────────────────────────────────────────────────
 package     * version date (UTC) lib source
 brio          1.1.3   2021-11-30 [3] CRAN (R 4.1.2)
 cachem        1.0.6   2021-08-19 [3] CRAN (R 4.1.1)
 callr         3.7.0   2021-04-20 [3] CRAN (R 4.1.1)
 cli           3.2.0   2022-02-14 [3] CRAN (R 4.1.2)
 crayon        1.5.1   2022-03-26 [1] CRAN (R 4.1.2)
 curl          4.3.2   2021-06-23 [3] CRAN (R 4.1.1)
 desc          1.4.0   2021-09-28 [3] CRAN (R 4.1.1)
 devtools      2.4.3   2021-11-30 [3] CRAN (R 4.1.2)
 ellipsis      0.3.2   2021-04-29 [3] CRAN (R 4.1.1)
 fastmap       1.1.0   2021-01-25 [3] CRAN (R 4.0.3)
 fs            1.5.2   2021-12-08 [3] CRAN (R 4.1.2)
 glue          1.6.1   2022-01-22 [3] CRAN (R 4.1.2)
 lifecycle     1.0.1   2021-09-24 [3] CRAN (R 4.1.1)
 magrittr      2.0.2   2022-01-26 [3] CRAN (R 4.1.2)
 memoise       2.0.1   2021-11-26 [3] CRAN (R 4.1.2)
 pkgbuild      1.3.1   2021-12-20 [3] CRAN (R 4.1.2)
 pkgload       1.2.4   2021-11-30 [3] CRAN (R 4.1.2)
 prettyunits   1.1.1   2020-01-24 [3] CRAN (R 4.0.1)
 processx      3.5.2   2021-04-30 [3] CRAN (R 4.1.1)
 ps            1.6.0   2021-02-28 [3] CRAN (R 4.1.1)
 purrr         0.3.4   2020-04-17 [3] CRAN (R 4.0.1)
 R6            2.5.1   2021-08-19 [3] CRAN (R 4.1.1)
 remotes       2.4.2   2021-11-30 [3] CRAN (R 4.1.2)
 rlang         1.0.4   2022-07-12 [1] CRAN (R 4.1.2)
 rprojroot     2.0.2   2020-11-15 [3] CRAN (R 4.0.3)
 sessioninfo * 1.2.2   2021-12-06 [3] CRAN (R 4.1.2)
 testthat      3.1.2   2022-01-20 [3] CRAN (R 4.1.2)
 usethis       2.1.5   2021-12-09 [3] CRAN (R 4.1.2)
 withr         2.4.3   2021-11-30 [3] CRAN (R 4.1.2)

 [1] /home/mhoffman/R/x86_64-pc-linux-gnu-library/4.1
 [2] /usr/local/lib/R/site-library
 [3] /usr/lib/R/site-library
 [4] /usr/lib/R/library