Feedbacks Milestone 3 - Githubissues

hadleyd2 / group_09-1

Repository for Daniel Hadley STAT 547M project

MIT License

0 stars 2 forks source link

Feedbacks Milestone 3 #1

Closed hadleyd2 closed 4 years ago

hadleyd2 commented 4 years ago

Copying feedback for milestone03 from the TA. Original Issue

Great work for the implementation of the feedbacks!

Try to keep the same size for your titles/ labels on your plots
Try to reduce the size of the plot where you do the linear regression, or plot the two graphs one under the other on the PDF, because we can't see the second plot
You should delete the Test-Hadley.Rmd and testiesTest files in the root of your repo
Give a more meaningful name to your correlogram (for example 'correlation between relevant variables')

Overall, great job! This is a very good project!!

hadleyd2 commented 4 years ago

Hello @sirine-chahma,

Thank you for the useful feedback! I will be addressing each of the four points you brought up in your feedback, as they are all practical should make the reader's experience more enjoyable.

I will update when resolved.

Thanks! -Dan

hadleyd2 commented 4 years ago

Hello @sirine-chahma,

Changed labels/titles of plots to be the same size per plot: https://github.com/hadleyd2/group_09-1/commit/909cb082895c49963ca612a5e8f7515f058c31be
Reduced size of QQ-plots to fit on page in pdf output: https://github.com/hadleyd2/group_09-1/commit/87d3edaacf7836dfaeeb6e78fcc122bb22e2942f
Deleted old files Test-Hadley.Rmd and testiesTest.Rmd: https://github.com/hadleyd2/group_09-1/commit/b5be774bdd8bf0e927c42a1b0c1481e28ddbdd68
More meaningful name given to correlogram: https://github.com/hadleyd2/group_09-1/commit/41803f9228ee4d7cb01240a6ae6fbd032892ee3c

Closing issue since work is now completed.

Thanks! -Dan