search

hadolint / hadolint-action

GitHub action for Hadolint, A Dockerfile linting tool
MIT License
194 stars 52 forks source link

Add problem matcher #10

Closed arnested closed 3 years ago

arnested commented 3 years ago

Add a problem matcher and let GitHub annotate pull requests:

problem-matcher
brpaz commented 3 years ago

Hey!

Thanks for this PR.

It was in my plans to have annotated pull requests some day.

But I didn't know about this "problem matcher" thing. :open_mouth:

It took me a while to find some documentation for it, hidden on actions toolkit repo.

It looks really cool and makes it a lot easier to create annotations without having to write specific code to parse the output and generate the annotations.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

arnested commented 3 years ago

Problem matchers is a very well-kept secret :) I read about half a year ago and nearly forgot about it again. I had to do quite some googling to find it again (not even remembering what it was called).

I'm sorry to say my PR didn't quite work, though: https://github.com/arnested/systemd-state/pull/54/checks?check_run_id=1504103163#step:4:6 (I had to try it out once it was merged).

I tested it out on a clone of this repos -- and there it worked because the problem-matcher.json actually is present in the repos which isn't the case once it's running on other repos.

I think I have a fix ready in a few minutes·.