search

hadolint / hadolint-action

GitHub action for Hadolint, A Dockerfile linting tool
MIT License
194 stars 52 forks source link

Fix problem matcher #14

Closed arnested closed 3 years ago

arnested commented 3 years ago

As mentioned in https://github.com/brpaz/hadolint-action/pull/10#issuecomment-739327662 the problem-matcher stuff didn't work because the definition is not present in the repository running the action.

An example of how it fails is: https://github.com/arnested/systemd-state/pull/54/checks?check_run_id=1504103163#step:4:6

This PR fixes the problem by adding the problem-matcher.json definition file to the Docker image and on runtime copying it into the repository.

An example of this PR doing its job and detecting and annotating errors can be seen here: https://github.com/arnested/systemd-state/pull/55/checks?check_run_id=1504185915#step:4:6

Sorry for the inconvenience, @brpaz.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: