search

hadolint / hadolint-action

GitHub action for Hadolint, A Dockerfile linting tool
MIT License
194 stars 52 forks source link

Feature: Recursive dir check - Lint multiple files #34

Closed itamargiv closed 3 years ago

itamargiv commented 3 years ago

This PR attempts to resolve the issue mentioned in #3. Although a simpler solution would be to try and enable passing glob patterns directly into the dockerfile parameter, it seems as though GH Actions passes these parameters to the entry point as strings which cannot be expanded without using eval which seemed a little risky to me.

I would be happy for any suggestion on how to improve this, as it might not be a complete solution, but was enough for my use case in wmde/wikibase-release-pipeline/pull/183.

lorenzo commented 3 years ago

sorry for the late review. Can you please fix the merge conflicts?

itamargiv commented 3 years ago

Hello, no worries about the timing, I've resolved the conflicts so far

lexfrei commented 3 years ago

@itamargiv any news?

itamargiv commented 3 years ago

@itamargiv any news?

I'd say we have to ask @lorenzo to re-review

lorenzo commented 3 years ago

thanks!