hadolint / hadolint-action

GitHub action for Hadolint, A Dockerfile linting tool
MIT License
192 stars 50 forks source link

Apply exit code to hadolint.sh #50

Closed paulbarton90 closed 2 years ago

paulbarton90 commented 2 years ago

Exiting with an exit code of 1 marks the job in github actions as a fail properly. This should help to fix #48. I have noticed that you need to explicitly add docker.io to the trusted registries when running the github action. I updated the testing action to run with the following configuration:

steps:
  - uses: actions/checkout@v2 
  - uses: hadolint/hadolint-action@v1.6.0
    with:
      dockerfile: Dockerfile
      trusted-registries: "docker.io"
lorenzo commented 2 years ago

thanks!

offa commented 2 years ago

Thank you!

paulbarton90 commented 2 years ago

No problem. I believe the "trusted-registries" part is also fixed so is not longer required when running in the action.