hadolint / hadolint-action

GitHub action for Hadolint, A Dockerfile linting tool
MIT License
192 stars 50 forks source link

Some `shellcheck` fixes and new input to print Hadolint results to console #68

Closed ViacheslavKudinov closed 1 year ago

ViacheslavKudinov commented 1 year ago

Could be considered as a potential fix of https://github.com/hadolint/hadolint-action/issues/60

Contains script injection fixes from https://github.com/hadolint/hadolint-action/pull/62

lorenzo commented 1 year ago

Thanks for your contribution! would you mind resolving the merge conflicts?

ViacheslavKudinov commented 1 year ago

Sure, I will take a look and update.

lorenzo commented 1 year ago

thanks!

ViacheslavKudinov commented 1 year ago

HI @lorenzo I see that this PR https://github.com/hadolint/hadolint-action/pull/71 changed behavior and input which I've added a kind of duplication to get output and useless. But if you can revert my PR merged to master, I can leave only Shellcheck things and remove unnecessary new input.

Or I can create PR by removing input related changes and leaving all other things.

I'm not sure there is a case when someone would like to output the result into some file, but still wants to see it via results-to-console on console 🤔

lorenzo commented 1 year ago

I'll revert

ViacheslavKudinov commented 1 year ago

Thanks a lot for the quick revert! Didn't want to get something useless released when realized the real outcome of another merged PR.