Fix of ShellCheck. Doc update. Int testing updates. Added ShellCheck job. - Githubissues

hadolint / hadolint-action

GitHub action for Hadolint, A Dockerfile linting tool

MIT License

192 stars 50 forks source link

Fix of ShellCheck. Doc update. Int testing updates. Added ShellCheck job. #74

Closed ViacheslavKudinov closed 1 year ago

ViacheslavKudinov commented 1 year ago

fixed ShellCheck concerns
added ShellCheck job as part of CI flow
updated Actions workflow to fix wrong names of steps
updated Readme file to add default values for few inputs
in workflow explicitly set permissions as they are needed for some Actions

ViacheslavKudinov commented 1 year ago

⚠️ With current configuration all concerns from ShellCheck will fail build on errors. In the PR's code https://github.com/hadolint/hadolint-action/pull/74/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR35 Link to the readme of GitHub action https://github.com/reviewdog/action-shellcheck#fail_on_error

lorenzo commented 1 year ago

thanks!