search

hadronized / glsl

GLSL parser for Rust
190 stars 28 forks source link

Only use needed features from nom #113

Closed jrmuizel closed 4 years ago

jrmuizel commented 4 years ago

Most importantly stop depending on the large lexical-core dependency.

This reduces clean build times from 11s to 8s for me.

hadronized commented 4 years ago

Woah, thanks. I didn’t know about those features.

jrmuizel commented 4 years ago

Do you mind doing a new release with this change?

hadronized commented 4 years ago

Yeah so I was thinking about it, and I’m going to revert that. lexical is a good library people will want most of the time. I’ll expose a flag to enable it and put as a default-feature.

hadronized commented 4 years ago

Hm, looks like float is only concerned. Okay, I need to investigate a bit more. That PR was merged to fast. :confused:

hadronized commented 4 years ago

Okay, so, I panicked a bit there. :rofl: We keep your PR and I’ll make a release, as I don’t use any lexical-core feature from nom. I’ll open an issue to do that.