hadronized / hop.nvim

Neovim motions on speed!
Other
2.47k stars 137 forks source link

would you consider adding HintDirection.{BEFORE,AFTER}_CURSOR_LINE? #320

Closed haolian9 closed 1 year ago

haolian9 commented 1 year ago

the *_LINE i mentioned means when determing the line region for targets, dont consider the current line. there are HintDirection.{BEFORE,AFTER}_CURSOR already, but they does not suffice my need perfectly.

in my use, i have three keymaps (listed above) for cursor movement, so when i pressed the rhs, i know where to find my targets.

the problem is that when i pressed sj or sk with the {BEFORE,AFTER}_CURSOR, Hop will allocate some marks for the current line, i'd like to avoid that.

so do you think it's worth to have those two directions?

(i have scratched a commit to add them, it does bring in more complexity)

hadronized commented 1 year ago

Hm, I don’t quite understand the need honestly. Can you give an example?

haolian9 commented 1 year ago

that's the result i desired when i pressed sj. 5f0d61bc-475d-11ed-b47a-54b203702c9c

hadronized commented 1 year ago

Oh okay, so basically you want a way to discard the current line. Yeah we could merge something like that, indeed. Feel free to open a PR.