Fix regression of #267 (Error: col val outside range)

hadronized / hop.nvim

Neovim motions on speed!

Other

2.47k stars 137 forks source link

Fix regression of #267 (Error: col val outside range) #341

Open spamwax opened 1 year ago

spamwax commented 1 year ago

Fix regression of phaazon/hop.nvim#267 caused by pull#315

opts.col passed to nvim_buf_set_extmark() expects it to be 0-indexed. phaazon/hop.nvim#315 causes an empty line to retun 1 for cursor's column. This PR checks if the current line is empty and sets the correct column in 'contexts' that'll be used later in nvim_buf_set_extmark() in set_unmatched_lines()

phgz commented 1 year ago

Is something preventing this PR from being merged?

brettmitchelldev commented 1 year ago

Been waiting for this for a while. I'm pinned to a previous (and pretty old) commit so that I can continue to use this plugin. I'm excited for this issue to be resolved so I can update.

gorillamoe commented 1 year ago

Until the maintainer finds time to maintain the PRs in this repo again, I'll try to get maintenance / somehow critical stuff into this fork: https://github.com/mistweaverco/hop.nvim

I cherry picked your commit into the master branch of the fork already :) Thanks for your effort!