search

hadware / voxpopuli

Python wrapper for Espeak and Mbrola, for simple local TTS
MIT License
28 stars 16 forks source link

Add tests to PyPi package #17

Open PureTryOut opened 3 years ago

PureTryOut commented 3 years ago

Please add the tests to the PyPi package. I'm packaging this for Alpine Linux and use the tagged release from PyPi, but those don't include the tests so we can't verify if the functionality of this package works at build time.

hadware commented 3 years ago

Hey,

By "adding the test to the Pypi package" what do you mean exactly (i'm not a "pro" packager by any means). Could you send me some example or reference to clarify what you meant?

Also, thanks for using voxpopuli. As a side question, and just out of curiosity, what will you be using it for?

PureTryOut commented 3 years ago

Well this git repository includes a folder called "tests". With this I can run pytest and it'll run various tests (created by you) to verify functionality. However, these tests are missing from the PyPi package, meaning I have no other way to verify functionality other than running the thing after packaging. I don't necessarily need the tests on PyPi, but I need them with tagged releases and it seems you don't create git tags, so in that case including them on PyPi is the way to go.

As for my use-case, I'm not personally using this but it's a dependency of https://github.com/HelloChatterbox/text2speech, which in turn is a dependency of a project (HiveMind) building on top of MyCroft.

hadware commented 3 years ago

Alright,good call, i'll try and fix that for you. I'll be putting my updates in a pypi-tests branch, so you can check if it fits your needs.

PureTryOut commented 3 years ago

Well if you don't publish that branch to PyPi, there isn't much I can test :wink:

May I ask why you don't tag release with git? That would for one fix my issue (as I don't need tests in PyPi persé, but mainly want a versioned source that includes the tests), but it would also allow you to go back to a previous version easily when for example bisecting or figuring out where bugs might have been introduced etc.

hadware commented 3 years ago

Well, since tagging looked like the easier way, I tagged. Tell me if everything is fine on your side.

May I ask why you don't tag release with git?

I don't know... I never felt like it was of any use since this is kind of a micropackage, and I thought I barely was the only one using it. Good to know that i was wrong!

PureTryOut commented 3 years ago

Closing since the solution as mentioned (tagged a Git release) works for me, thanks! :+1:

PureTryOut commented 3 years ago

@hadware seems 0.3.7 is out but there isn't a Git tag for it. Could you please start getting used to proper Git workflows and start tagging your releases?

PureTryOut commented 3 years ago

Re-opening as there isn't a Git tag for 0.3.7 and the tests are not included in the PyPi package yet.