hadynz / obsidian-kindle-plugin

Sync your Kindle notes and highlights directly into your Obsidian vault
MIT License
922 stars 52 forks source link

[BUG] Kindle link does not navigate to highlight location if Kindle app is open (Windows) #198

Open mikegomezg opened 1 year ago

mikegomezg commented 1 year ago

Describe the bug

When I click a link like the one below in Obsidian, the Kindle app only navigates to the link's location if the app is not open or if I have selected another book. If the app is already open and I have the book open with highlights that I have synced to Obsidian, clicking a link in any of the highlights for that book switches focus to the Kindle app, but it does not change the current page.

kindle://book?action=open&asin=B7B9AY3XZZ&location=301

Method of syncing

To Reproduce

Steps to reproduce the behaviour:

  1. Open the Kindle app on a Windows device (I haven't tested the behavior on a Mac). Open the target book that has highlights you have already synced to Obsidian.
  2. Go to the page in Obsidian that got generated when you imported highlights from that book with the Kindle Highlights plugin.
  3. Click on a location page number link for any highlight.
  4. Observe that the current page does not change.
  5. No errors appear in the Dev Tools console when I click a link.

Expected behaviour

I expect the current page to change so that I can see the page that contains the highlight I clicked in Obsidian.

Screenshots

If applicable, add screenshots to help explain your problem.

Metadata

mikegomezg commented 1 year ago

Could the problem be with the URL action (e.g. "open") ? Is there another URL action we could use? I wasn't able to find online where the different actions are for the Kindle URLs.

rviljoen commented 1 year ago

Seems like this may be a known issue with deep-linking support on the Kindle apps: https://www.reddit.com/r/readwise/comments/w3qa0x/view_in_kindle_desktop_not_working_as_expected_a