search

hadynz / obsidian-kindle-plugin

Sync your Kindle notes and highlights directly into your Obsidian vault
MIT License
897 stars 52 forks source link

[BUG] Region is not used in the product page URL. #252

Open naokiy opened 1 year ago

naokiy commented 1 year ago

Describe the bug

Even if Region is set to other than Global, the URL generated will be the Global one. If the book does not exist on amazon.com, the URL will be 404.

It may be due to the presence of "amazon.com" in the following line. https://github.com/hadynz/obsidian-kindle-plugin/blob/master/src/scraper/scrapeBooks.ts#LL50C7-L50C7

Method of syncing

To Reproduce

Steps to reproduce the behaviour:

  1. Set Region to something other than Global.
  2. Sync with Amazon Kindle Reader
  3. See generated file.

Expected behaviour

The URL corresponding to Region is generated. For example, in Japan, https://www.amazon.co.jp/dp/XXXXXXXX

Metadata