search

hadynz / obsidian-kindle-plugin

Sync your Kindle notes and highlights directly into your Obsidian vault
MIT License
897 stars 52 forks source link

Convert Book ID's to MD5 to reduce collisions #274

Open shaunbarlow opened 6 months ago

shaunbarlow commented 6 months ago

Keep fletcher hashes for the highlight refs.

Retains backwards compatibility with notes that store the old fletcher hashes, and will update them as new highlights are added

This is my attempt to fix this

Why

I have two books that have their highlights merged to to being assigned the same bookID with the current hash used. I want to be able to have them seperate, but otherwise cause as little disruption as possible.

For interest, the two books are "The One Year Bible TLB" and "How to Develop Your Personal Mission Statement" 🤷

sancg commented 4 months ago

Hi Sr @shaunbarlow, is the hash used to track on which file new notes will be added? How does it work? As you mentioned, if it is to distinguish 2 books, why did the last way of Hashing collide with "The One Year Bible" TLB and "The One Year Bible TLB". I'm creating from scratch a script that makes the same as this plugin and I would like to collaborate on this one, but I get lost when reading the code.