search

hadynz / obsidian-kindle-plugin

Sync your Kindle notes and highlights directly into your Obsidian vault
MIT License
897 stars 52 forks source link

[BUG] Can't sign out of Amazon #289

Open Soulstorm646 opened 1 month ago

Soulstorm646 commented 1 month ago

Describe the bug

After logging in to my Amazon account and syncing my highlights, I would like to sign out as suggested in the Security section of Git Hub. I click the Sign Out button in the settings but it does not work.

Method of syncing

To Reproduce

Steps to reproduce the behaviour:

  1. Log into Amazon Account (amazon.fr)
  2. Sync highlights
  3. Click Sign Out in plugin settings

Screenshots

Notifications: image Developer Console image

Metadata

Thank you in advance for your help !

frankmarazita commented 2 weeks ago

Having the same issue, looks like the method for sign out that this plugin uses needs to be updated as the kindle site may have changed.

From what I can tell, it points to https://read.amazon.com and tries to find the link for the sign out button on the page with the id #settings-link-logout. It can't find it in the dom object it gets back so it throws this error.

https://github.com/hadynz/obsidian-kindle-plugin/blob/99cab6ec7f34c1cf98fed50232773cdac265a698/src/settings/index.ts#L83

https://github.com/hadynz/obsidian-kindle-plugin/blob/99cab6ec7f34c1cf98fed50232773cdac265a698/src/scraper/scrapeLogoutUrl.ts#L14

Looks like the last time this plugin was updated was over a year ago, not sure if we will see a fix from the developer any time soon.

Honestly, I haven't even been able to get any of the Amazon Cloud sync functionality working, only able to use it via manual file upload for now.

I hope this and other issues get fixed since it's a great plugin.

jacobproffer commented 2 weeks ago

Has anyone found a workaround, other than deleting the plugin from Obsidian?

realizetm commented 1 week ago

seems it won't then allow you the opportunity to sign in when the plugin has been removed, obsidian closed, and then re-added.

hadynz commented 1 week ago

Hey everyone. I've just been made aware of this thread today.

It sounds like as you said the method for parsing logout has changed.

Suggested workaround: Open Obsidian dev tools, and clear the app's cookies and sessions. Obsidian is essentially running in a Google Chrome browser. So any instructions online for the latter would work for you.

I am going on extended leave from my job in September so will aim to be active on this plugin's development again then.