hadynz / obsidian-kindle-plugin

Sync your Kindle notes and highlights directly into your Obsidian vault
MIT License
966 stars 55 forks source link

[BUG] In obsidian 1.7.4, sync errors prevents app from starting #301

Open deafmute1 opened 1 month ago

deafmute1 commented 1 month ago

Describe the bug

in Obsidian 1.7.4, the new startup load time optimization feature flags this plugin at start up as "taking a long time to load" and offers the option to disable this plugin. Unless you disable the plugin, Obsidian will never load at startup.

The plugin loads and seems to operate fine (i.e. with no new bugs) if manually enabled after startup.

Method of syncing

Expected behaviour

Vault should be loadable with this plugin enabled

Screenshots

If applicable, add screenshots to help explain your problem.

Metadata

deafmute1 commented 1 month ago

Okay, I let the load process run out for longer, and I found that there is a sync error in console for what appears to be every single book. This appears to be a bug with syncing that is triggered at obsidian start up by enabling "Sync at Startup".

After rerunning the manual sync a few times, these errors went away (despite reloading obsidian half a dozen times and getting the same errors). I'm not sure if this is due to the plugin somehow marking these as failed and giving up, or if rerunning it a bunch of times managed to jostle something into place and fix it. Either way, this error/bug has stopped for me, at least for now

Sync error: Error syncing book {id: '26035', asin: 'B010PQAUH6', title: 'Oathbringer: The Stormlight Archive Book Three', author: 'Brandon Sanderson', url: 'https://www.amazon.com/dp/B010PQAUH6', …}asin: "B010PQAUH6"author: "Brandon Sanderson"id: "26035"imageUrl: "https://m.media-amazon.com/images/I/91v0vIqvFlL._SY160.jpg"lastAnnotatedDate: Thu Jan 10 2019 00:00:00 GMT+1100 (Australian Eastern Daylight Time) {}title: "Oathbringer: The Stormlight Archive Book Three"url: "https://www.amazon.com/dp/B010PQAUH6"[[Prototype]]: Object t {name: 'YAMLException', reason: 'incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line', mark: r, message: 'incomplete explicit mapping pair; a key node is mi… B010PQAUH6\n ^', stack: 'YAMLException: incomplete explicit mapping pair; a…r.onload (plugin:obsidian-kindle-plugin:303:4152)'}

woodae99 commented 1 month ago

I have the same issue

aignaciodc commented 3 weeks ago

Ditto, still. So just keep disabling and re-enabling until it stops?

ggrant2001 commented 3 weeks ago

I had this issue, disabled the plugin during the load. After Obsidian loaded, I reenabled the plugin, then went to Kindle Highlights settings, and disabled "Sync at Startup". That seemed to fix the issue.