search

hadynz / obsidian-kindle-plugin

Sync your Kindle notes and highlights directly into your Obsidian vault
MIT License
963 stars 55 forks source link

Not syncing long notes!! #Bug #52

Closed doodoo787 closed 3 years ago

doodoo787 commented 3 years ago

1st: AWESOME plugin!! I love it so much!! Especially the fact that I can "style" my notes with markdown is so neat!

However, the plugin doesn't seam to be working correctly anymore.

Info: Plugin is connected to my Amazon Account.

  1. Synced book for testing reasons (since I wasn't finished reading)
  2. Sync happened as expected. (up to the most current note)
  3. Deleted book note in Obsidian (Because Plugin won't sync again if the book is already there)
  4. Synced book.
  5. Sync happened. However, it seams that only an old version of my notes is being synced. A ton of new notes are not transmitted. (I'm pretty sure it did work the first one or two times I tried it and updated to the most current note-- it just stopped working recently)

Help. Please.

hadynz commented 3 years ago

Thanks for creating this issue and bringing it to my attention.

On first read, I think you were running into the problem described in https://github.com/hadynz/obsidian-kindle-plugin/issues/38, were the plugin will skip syncing a book and its highlights if it has been synced before, and exists in Obsidian.

Deleted book note in Obsidian (Because Plugin won't sync again if the book is already there) However, given that you've correctly done the right step to force the plugin to resync, I am surprised that your highlights have not come through.

Can I ask you to confirm if you can see the highlights that you are expecting on https://read.amazon.com/notebook? The plugin should output an exact replica of what it sees there.

doodoo787 commented 3 years ago

Thanks for your quick response!!

  1. "Deleting and syncing afterwards" has lead to the "correct and current notes" several times before it stopped working.
  2. Yes, the link you offered shows all the correct notes.
  3. I just tried deleting and syncing again. It still only gets my notes up to a certain point (that hasn't changed for days).

To me it feels as if "my notes are too long" and it sounds a little bit like this problem: https://github.com/hadynz/obsidian-kindle-plugin/issues/14

So I went ahead and took a screenshot of the source code of my booknotes page ( https://read.amazon.com/notebook ) because that helped with the other problem:

Screenshot 2021-06-05 at 07 54 07

Hope that helps! Please tell me if I can be of further assistance.

doodoo787 commented 3 years ago

I just tried syncing a different book. One I had read a long time ago, with very old (and very few) notes.

  1. I added a note at the end.
  2. I double checked that the note was visible online.
  3. I deleted the note from Obsidian.
  4. I synced the book again.
  5. The book note reappeared as expected.
  6. All the notes were there! Even the new one.

Hence, I guess, it has to have something to do with either file length, or number of highlights, or number of notes.

hadynz commented 3 years ago

Can you take a screenshot of a highlight or a note that you can see on read.amazon.com/notebook that is not syncing with the plug-in?

It will help me recreate the problem at my end if I see what it looks like.

On Sat, 5 Jun 2021 at 6:06 PM, doodoo787 @.***> wrote:

I just tried syncing a different book. One I had read a long time ago, with very old (and very few) notes.

  1. I added a note at the end.
  2. I double checked that the note was visible online.
  3. I deleted the note from Obsidian.
  4. I synced the book again.
  5. The book note reappeared as expected.
  6. All the notes were there! Even the new one.

Hence, I guess, it has to have something to do with either file length, or number of highlights, or number of notes.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hadynz/obsidian-kindle-plugin/issues/52#issuecomment-855190496, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACNBQJQYR5WB3ZL3ZSKTWTTRG5HRANCNFSM46CZ7NVA .

-- Sent from Gmail Mobile

doodoo787 commented 3 years ago

Sorry, I'm not exactly sure what you need. Here is the book I'm having problems with. Plus the first couple of notes (these notes will always sync):

Screenshot 2021-06-05 at 09 15 26

===

When I srcoll way down, I will find the notes which are not syncing. Screenshot coming up:

Here "Write exactly one note for each idea ..." is the last highlite+note that will sync. And "4. Now add your new permanent..." is the first highlight that will not sync.

Screenshot 2021-06-05 at 09 17 43

=== Here is the html of this area:

Note that works:

Screenshot 2021-06-05 at 09 21 17

=== Note that doesn't work:

Screenshot 2021-06-05 at 09 21 50

=== Is that what you need?

hadynz commented 3 years ago

Interesting.

Can I confirm that no other highlights after “Write exactly...” are coming through?

If that’s the case, this eliminates this being an issue of note or highlight text size. It looks like a pagination issue. You have so many highlights (172) and they are loaded in multiples pages. The plug-in might not be catering for that. But that would be an easy fix if this indeed the issue.

On Sat, 5 Jun 2021 at 7:23 PM, doodoo787 @.***> wrote:

I'm not exactly sure what you need. Here is the book I'm having problems with. Plus the first couple of notes (these notes will always sync): [image: Screenshot 2021-06-05 at 09 15 26] https://user-images.githubusercontent.com/37766182/120883671-c8f76480-c5de-11eb-9e53-57f30d221f4a.png Here "Write exactly one note for each idea ..." is the last highlite+note that will link. And "4. Now add your new permanent..." is the first highlight that will not sync. [image: Screenshot 2021-06-05 at 09 17 43] https://user-images.githubusercontent.com/37766182/120883694-f512e580-c5de-11eb-998f-6c8a260398b5.png Here is the html of this area: Note that works: [image: Screenshot 2021-06-05 at 09 21 17] https://user-images.githubusercontent.com/37766182/120883794-7e2a1c80-c5df-11eb-9392-7b9335921aec.png Note that doesn't work: [image: Screenshot 2021-06-05 at 09 21 50] https://user-images.githubusercontent.com/37766182/120883803-897d4800-c5df-11eb-8ead-6d48f6fe84e1.png

Is that what you need?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hadynz/obsidian-kindle-plugin/issues/52#issuecomment-855198221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACNBQPADJUNKAYB3ZIZ42LTRHGFPANCNFSM46CZ7NVA .

-- Sent from Gmail Mobile

doodoo787 commented 3 years ago

Can I confirm that no other highlights after “Write exactly...” are coming through?

Yes. That is exactly the case.

hadynz commented 3 years ago

I've been able to recreate this problem @doodoo787. It is actually happening with several books that I have with a large number of highlights. This is quite the bug! Glad you raised it. Will let you know as soon as I release a fix for you to try.

doodoo787 commented 3 years ago

So looking forward to this!! fingers crossed

hadynz commented 3 years ago

I've made a fix. Are you able to download the latest version 0.2.15 and let me know if that resolves the issue at your end too?

doodoo787 commented 3 years ago

Downloaded. Tested. Works like a charme!!! So awesome! Thank you so much!

hadynz commented 3 years ago

Awesome to hear @doodoo787. Closing this issue then since the bug seems to be resolved for now.