haegar / mod-auth-external

Slightly modified Apache mod-auth-external, based on code.google.com export.
5 stars 1 forks source link

Group Authentication not passing 'GROUP' env or argv variables #11

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Regular Setup

What is the expected output? What do you see instead?
Using PHP "print_r($_SERVER['GROUP'])" is empty, i expect to see the group name 
via
Require external-group developer test

What version of the product are you using? On what operating system?
3.3.1

Please provide any additional information below.
'GROUP' variable is not being passed to external script

Original issue reported on code.google.com by ddarby...@iconicgroup.ca on 17 Jul 2013 at 1:33

GoogleCodeExporter commented 8 years ago
This might be a bug against Apache 2.4. I ended up getting this to work by 
using the old style syntax:

AddExternalGroup <keyword> <location>
SetExternalGroupMethod <keyword> <method>

The new style does not pass the GROUP variable

Original comment by ddarby...@iconicgroup.ca on 17 Jul 2013 at 2:29

GoogleCodeExporter commented 8 years ago
There is a bug in the function def_extgroup. The result is that 
DefineExternalGroup doesn't take method argument, but uses default one (pipe) 
instead.

Change the line:
    apr_table_set( svr->group_method, keyword, DEFAULT_METHOD );
to
    apr_table_set( svr->group_method, keyword, method );
should work.

/* Handler for a DefineExternalGroup server config line */
static const char *def_extgroup(cmd_parms *cmd, void *dummy,
    const char *keyword, const char *method, const char *path)
{
    authnz_external_svr_config_rec *svr= (authnz_external_svr_config_rec *)
    ap_get_module_config( cmd->server->module_config,
        &authnz_external_module);

    apr_table_set( svr->group_path,   keyword, path );
    apr_table_set( svr->group_method, keyword, DEFAULT_METHOD );

    return NULL;
}

Original comment by Guoan...@gmail.com on 11 Nov 2013 at 2:14

GoogleCodeExporter commented 8 years ago
Thanks for the bug report and fix. The fix will be included in the 3.3.2 
release which I hope to get out today.

Original comment by j...@unixpapa.com on 11 Dec 2013 at 7:22

GoogleCodeExporter commented 8 years ago

Original comment by j...@unixpapa.com on 11 Dec 2013 at 7:25