[Assignment 1] Review

[minhchau273]

:+1: Nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Excellent
• Code Style: Good
• Visual Design: Excellent

  Overall: Excellent

  Detailed Notes

• Be sure to follow the Swift code styling conventions for the homework. Please read this style guide for more detail. Style is important!
  • Ray Wenderlich Swift Style Guide
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response. For a more robust solution, you can also investigate using an ORM like Pistachio.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Nice work implementing the error message on network failure. However, there's a tiny issue with the refresh control after turning the wifi.
  
• Nice job implementing a UITextView. But the users cannot see the whole text because it was overlapped by the tab bar.
• Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read Design tips for iOS9.
• Great work implementing the collection view. It'd be better if you replaced this white space with the search bar. One more thing, the poster in the collection view is not tappable.
• 👍 for the search bar. Sorry for the confusing in the requirements. The search feature in this assignment is simply a filter for the current list of movies. But you might load wrong data for the table view when searching.
  
• Nice work adding the animation for the posters.
• I love your detail screen with more information about the movie. Nevertheless, for now, I can edit the title and release date. 😛
  
• I really enjoy your tab bar. It's cool. 🍡

Great job dedicating enough time to do the homework. I really appreciate your hard work. You learned a lot! Keep up the good work. 🍨 🍭

[minhchau273]

One more thing, do you realize you have 2 duplicated files in your project?