search

haesbaert / mdnsd

Mdns daemon for OpenBSD.
www.haesbaert.org/openmdns
136 stars 27 forks source link

suggested fix for rr_rdata_cmp() #2

Closed ago closed 11 years ago

ago commented 11 years ago

Hi!

Probably you should replace condition in rr_rdata_cmp() this way: (RR_INADDRANY(rra) || RR_INADDRANY(rra)) -> (RR_INADDRANY(rra) || RR_INADDRANY(rrb))

haesbaert commented 11 years ago

On Dec 24, 2012 1:57 PM, "Alexander Gordeev" notifications@github.com wrote:

Hi!

Probably you should replace condition in rr_rdata_cmp() this way: (RR_INADDRANY(rra) || RR_INADDRANY(rra)) -> (RR_INADDRANY(rra) || RR_INADDRANY(rrb))

Indeed that is wrong, Im on holidays now but will fix as soon as i get home.

Are you using mdnsd ? I got so many reports latrly that Im considering getting back to it.

— Reply to this email directly or view it on GitHub.

ago commented 11 years ago

Actually, I'm dissecting it to use it in my product as a standalone MDNS library. :) So thank you for the good code! I'll share back if I have something interesting.

haesbaert commented 11 years ago

On Dec 24, 2012 2:51 PM, "Alexander Gordeev" notifications@github.com wrote:

Actually, I'm dissecting it to use it in my product as a standalone MDNS library. :) So thank you for the good code!

—

Nice, if you dont mind letting me know of your progress I might be a little more motivated, I stopped developing since I didnt get much feedback in the past.

Reply to this email directly or view it on GitHub.

ago commented 11 years ago

Ok, sure.

haesbaert commented 11 years ago

Fixed in a3f7466b4a07cdcaba642983ae6e2da6ecfd1fd1