haesleinhuepf / BioImageAnalysisNotebooks

Python Jupyter notebooks for BioImageAnalysis, GPU-accelerated image processing, bio-image data science and more
https://haesleinhuepf.github.io/BioImageAnalysisNotebooks
BSD 3-Clause "New" or "Revised" License
123 stars 35 forks source link

Navbar not working on iPad in portrait mode #34

Closed iimog closed 2 months ago

iimog commented 1 year ago

I'm mainly reading the notebooks on my iPad in portrait mode. A couple of weeks ago, the navbar stopped working. When I click on the icon at the top left, the screen turns dim but the navbar does not open. It works in landscape mode, in the browser and on my phone. But I'm able to reproduce the problem in Firefox Mobile view (Ctrl+Shift+M) when selecting iPad there.

I tracked the issue down to this commit: https://github.com/haesleinhuepf/BioImageAnalysisNotebooks/commit/2cd4c3583aa28d29176a7f441dc488a1eb9af040 Indeed, when upgrading to sphinx-book-theme version 1.0.1 the sidebar works on my iPad. However, the search icon is back in the middle, rather than the navbar.

iimog commented 2 months ago

In the current sphinx-book-theme version 1.1.3 the search bar is back in the sidenav. The overall layout and design looks very similar when updating. And the navbar also works again on the iPad. You might consider removing the restriction of sphinx-book-theme to versions before 1.0.0. Below is a screenshot of the page with the new version. image

haesleinhuepf commented 2 months ago

Below is a screenshot of the page with the new version

Wow cool! Can you please send this as pull-request? I would love to merge it!

iimog commented 2 months ago

With pleasure.

These notebooks are such a great resource. I used some of their content for teaching a course twice, and I regularly refer students here. I'm very happy to contribute some minor improvements, particularly as this project is managed in such a welcoming way. :smiley:

github-actions[bot] commented 2 months ago

This message was generated by git-bob 0.1.1, an AI-based assistant.

Hi @iimog,

thanks for reaching out! Unfortunately, I'm not allowed to respond to you directly. I need approval from a repository member: @haesleinhuepf

Best, git-bob