haesleinhuepf / devbio-napari

BSD 3-Clause "New" or "Revised" License
43 stars 13 forks source link

got windows installer to work #48

Open thawn opened 9 months ago

thawn commented 9 months ago

The windows installer created by constructor installer\Win works now.

I had to create a workaround for the start menu entries, because I could not get "napari-menu" to play nicely with constructor (possibly because of #49).

Therefore, I created my own shortcut.json and installed that via a post-install.bat script.

The clean solution would be to create our own conda package (e.g. devbio-napari-shortcut) that installs devbio-napari_shortcut.json and the .ico file into %PREFIX%\Menu. That would then work the same way as napari-menu (but currently only for windows).

thawn commented 9 months ago

here is the windows installer for download feel free to test it ;-)

thawn commented 8 months ago

Currently, I added some packages with restrictive licenses (e.g. pyqt) so that it runs out of the box. As discussed offline with @haesleinhuepf , one way to deal with this would be to make two installers, one with a restrictive license that comes with everything, and one with a permissive license that requires additional work by the user (or at least requires the user to check a box in the installer that runs a post-install script which installs the missing packages)

zoccoler commented 8 months ago

Hi @thawn ,

@stefanhahmann and I just tested it. The installation works, but it does not open (it opens a black console screen and after a few moments closes itself). We think this naparia-script.py is missing (specified in the shortcut.json file), we could not find it anywhere in your fork (under "construct" branch at least).

thawn commented 8 months ago

@zoccoler @stefanhahmann thanks a lot for testing! I remember that I had the same issue at some point. I will look into it. Unfortunately, I don't have access to the windows machine where I got it to work at the moment. Let's have a look at it together in the afternoon.