haesleinhuepf / napari-assistant

BSD 3-Clause "New" or "Revised" License
20 stars 5 forks source link

Workflow undo functionality #12

Closed Cryaaa closed 2 years ago

Cryaaa commented 2 years ago

@haesleinhuepf: Here is the other part to undo and redo which lives in the napari assistant. It's quite a lot of changes but some testing notebooks can be removed later on as well. Again I am turning this into a draft since some docstrings might be needed here and there as well as some annotations but overall this works for me. Furthermore #11 should be merged beforehand as this branch builds on the changes made there. It would also be good if testing is now done with other people. Let me know what you think and who I should maybe tag (we can also do this in a group meeting).

haesleinhuepf commented 2 years ago

Codecov Report

Merging #12 (f723c1f) into main (2f0d159) will decrease coverage by 2.91%. The diff coverage is 5.67%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   30.15%   27.23%   -2.92%     
==========================================
  Files          12       13       +1     
  Lines         892     1028     +136     
==========================================
+ Hits          269      280      +11     
- Misses        623      748     +125     
Impacted Files Coverage Δ
napari_assistant/_undo_redo.py 0.00% <0.00%> (ø)
napari_assistant/_workflow_io_utility.py 0.00% <0.00%> (ø)
napari_assistant/_gui/_category_widget.py 14.42% <8.77%> (-0.67%) :arrow_down:
napari_assistant/_gui/_Assistant.py 31.25% <9.09%> (-6.85%) :arrow_down:
napari_assistant/_categories.py 52.94% <13.33%> (-3.46%) :arrow_down:
napari_assistant/_gui/_button_grid.py 96.96% <0.00%> (+3.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f0d159...f723c1f. Read the comment docs.

Cryaaa commented 2 years ago

Also the button for undo and redo is really annoying at the moment because it is right at the bottom and it should be a button for undo and a button for redo imo.

Cryaaa commented 2 years ago

15 needs to be solved before we can think about merging.

haesleinhuepf commented 2 years ago

Thanks Ryan @Cryaaa !

Cryaaa commented 2 years ago

This PR also closes #2