haesleinhuepf / napari-assistant

BSD 3-Clause "New" or "Revised" License
20 stars 5 forks source link

Use napari default blending if not set by Category #19

Closed psobolewskiPhD closed 2 years ago

psobolewskiPhD commented 2 years ago

This PR adresses https://github.com/haesleinhuepf/napari-assistant/issues/18 Basically, instead of setting a default blending in napari-assisant Category class, the default is left as None such that it is handled by napari. In napari 0.4.15 this will still be translucent but in napari 0.4.16 the new default is translucent_no_depth. Specific categories that had previously hard-set translucent are also now just using the default, because it wasn't clear that they require depth checking (or not). Categories that specifically set other blending modes, such as Mesh that set additive, continue to use their custom modes.

I tested this locally with both 0.4.15 and 0.4.16 testing a few of the different workflow operations, including the workflow originally posted in the napari issue https://github.com/napari/napari/issues/4618 Everything behaved correctly.