search

haesleinhuepf / napari-assistant

BSD 3-Clause "New" or "Revised" License
20 stars 5 forks source link

Fix workflow loading #22

Closed Cryaaa closed 2 years ago

Cryaaa commented 2 years ago

I found a new bug when loading workflows, where the category of a function couldn't be found. I traced this back to the addition of the timeslicer to dask functions which meant we were comparing wrapped functions with the original functions. The added line during the comparison circumvents this issue.

haesleinhuepf commented 2 years ago

Codecov Report

Merging #22 (106d489) into main (4612a38) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   28.89%   28.89%           
=======================================
  Files          13       13           
  Lines        1007     1007           
=======================================
  Hits          291      291           
  Misses        716      716
Impacted Files Coverage Δ
napari_assistant/_categories.py 60.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4612a38...106d489. Read the comment docs.

haesleinhuepf commented 2 years ago

Awesome, thanks for this @Cryaaa !