haesleinhuepf / napari-assistant

BSD 3-Clause "New" or "Revised" License
20 stars 5 forks source link

Next step suggestions #23

Closed Cryaaa closed 2 years ago

Cryaaa commented 2 years ago

This is the implementation of the next step suggestions. As we discussed I added a parameter to the categories which includes a list of suggetsed category names for the next steps. I have added the next step suggestions purely based on my thoughts when looking at the categories and I think we should have a discussion about them before doing the final implementation (that's why this is a draft).

The highlighting of the next steps meant that a few changes to the button grid had to be made but the final result does not differ from the design much in my opinion. CUrrently highlighting is done by changing the background of the items to green which I think looks nice. During the development I noticed a bug which is fixed in #22 and thus should be merged beforehand. Finally I slightly modified the get_category_of_function function to allow only searching by function name, which makes life a bit easier for determining categories from loaded widgets.

haesleinhuepf commented 2 years ago

Codecov Report

Merging #23 (d6d6a23) into main (4612a38) will increase coverage by 1.28%. The diff coverage is 64.81%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   28.89%   30.18%   +1.28%     
==========================================
  Files          13       13              
  Lines        1007     1047      +40     
==========================================
+ Hits          291      316      +25     
- Misses        716      731      +15     
Impacted Files Coverage Δ
napari_assistant/_workflow_io_utility.py 0.00% <0.00%> (ø)
napari_assistant/_categories.py 60.00% <40.00%> (-0.11%) :arrow_down:
napari_assistant/_gui/_Assistant.py 34.43% <65.51%> (+1.62%) :arrow_up:
napari_assistant/_gui/_button_grid.py 86.00% <72.22%> (-7.94%) :arrow_down:
napari_assistant/_gui/_category_widget.py 14.47% <100.00%> (+0.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4612a38...d6d6a23. Read the comment docs.

Cryaaa commented 2 years ago

@haesleinhuepf, I have made some changes to the menu, making the hints more subtle and I've got 2 versions now (one brighter and one less bright) where I can't decide which is better (see below)... The menu is definitely back to how it was after the commit though I had to change the minimum width a bit (now it is 340px instead of 294). Do you think this is a problem? Personally I feel that it isn't too big but maybe there was a reason for the previous minimum width?

From my side we could merge after deciding on the color :)

demonstrate changes to napari assistant menu

haesleinhuepf commented 2 years ago

Awesome, I go for the darker option and see how it looks in the wild. Thanks again!