fix error when mesh not clicked

haesleinhuepf / napari-process-points-and-surfaces

Process and analyze surfaces using vedo in napari.

BSD 3-Clause "New" or "Revised" License

21 stars 4 forks source link

fix error when mesh not clicked #26

Closed kevinyamauchi closed 1 year ago

kevinyamauchi commented 1 year ago

This PR is a proposed fix for the error when the mesh is not clicked in the surface painting code. When the mesh is not intersected by a click, layer.get_value returns None for triangle_index, which causes all vertices to be painted in the SurfaceAnnotationWidget._paint_face() method.

haesleinhuepf commented 1 year ago

Hi Johannes @jo-mueller ,

just some minor feedback: A request to review is not a request to merge ;-) This time it was ok. Next time, please just review. I might also want to have a look before merging.

Thanks!

Best, Robert