search

haesleinhuepf / napari-process-points-and-surfaces

Process and analyze surfaces using vedo in napari.
BSD 3-Clause "New" or "Revised" License
21 stars 4 forks source link

Apply scale parameter #6

Open jo-mueller opened 2 years ago

jo-mueller commented 2 years ago

When working with parameters like curvature, I think it is dangerous to have the scale parameter set in the layer properties. ´This could lead to a sphere appearing perfectly spherical while, in fact, being ellipsoidal.

We could fix this by introducing a small function that "applies" the scale parameter to the points in points/surface layers as this wouldn't change the actual amount of data to be handled - unlike with image data.

haesleinhuepf commented 2 years ago

Then it would also make sense to multiply the voxel size with the vertices, after applying marching cubes, right?

E.g. here: https://github.com/haesleinhuepf/napari-process-points-and-surfaces/blob/main/napari_process_points_and_surfaces/__init__.py#L424

And the opposite should be done here, I think: https://github.com/haesleinhuepf/napari-process-points-and-surfaces/blob/main/napari_process_points_and_surfaces/__init__.py#L333

jo-mueller commented 2 years ago

Yes, exactly! PR coming soon 👍