haesleinhuepf / napari-workflows

BSD 3-Clause "New" or "Revised" License
12 stars 10 forks source link

Restoring widgets from workflow #12

Closed jo-mueller closed 2 years ago

jo-mueller commented 2 years ago

@haesleinhuepf @Cryaaa

since we were debatting yesterday about this project (and I think already went a few steps in this direction), do you have any preferences about where such a function should reside? I could see it in napari-workflows:

Just creating this issue to keep track of the project, feel free to delete it if it has been created elsewhere.

haesleinhuepf commented 2 years ago

Very good! I was thinking again of where to put the code for this and I think the right place would be the assistant repository, because the assistant allows to build workflows.

haesleinhuepf commented 2 years ago

It would require to make napari-tools-menu (make_gui(), specifically) part of the dependencies to hook the restored widgets to the workflow functionality

That actually makes sense. Alternatively, we could move the make_gui code here, and use it from napari-tools-menu.

Cryaaa commented 2 years ago

Since we want to implement the save and load workflow functions into the workflow inspector plugin, should the code maybe reside there? I mean we mostly need the GUI creation when we are working in napari so for me at least it makes sense to keep the code there.

jo-mueller commented 2 years ago

workflow inspector plugin, should the code maybe reside there?

True that. Both napari-workflows and napari-tools-menu are already in the dependencies of the workflow inspector, so this makes sense to me, too.

haesleinhuepf commented 2 years ago

The problem with the inspector is that the code there is GPL-licensed and hence license-incompatible with other repositories. I would prefer to see the I/O functionality in the assistant.

Cryaaa commented 2 years ago

This issue has now been solved in the napari assistant and the code for it was introduced here.