Review 27.05.2020 - Githubissues

haevg-rz / MentorSpeedDatingApp

A Trainee's project for planning a Mentor Speed Dating event

MIT License

1 stars 0 forks source link

Review 27.05.2020 #23

Closed dhcgn closed 4 years ago

dhcgn commented 4 years ago

[x] Unused PrintMatchingCommand in MainWindow https://github.com/haevg-rz/MentorSpeedDatingApp/blob/c712e37f15b81c3c906d015936cbc91de5bb49c0/MentorSpeedDatingApp/Views/MainWindow.xaml#L203
[x] Using styles for DataGrid in MainWindow https://github.com/haevg-rz/MentorSpeedDatingApp/blob/c712e37f15b81c3c906d015936cbc91de5bb49c0/MentorSpeedDatingApp/Views/MainWindow.xaml#L103-L118
[x] Avoid dynamic in MatchingViewModel https://github.com/haevg-rz/MentorSpeedDatingApp/blob/c712e37f15b81c3c906d015936cbc91de5bb49c0/MentorSpeedDatingApp/ViewModel/MatchingViewModel.cs#L21
[x] Not 'blendable' MatchingWindow
[x] Why build a DataGridTextColumn and not using a style? https://github.com/haevg-rz/MentorSpeedDatingApp/blob/c712e37f15b81c3c906d015936cbc91de5bb49c0/MentorSpeedDatingApp/ExtraFunctions/DataGridCreator.cs#L15
[x] How should this work in production? https://github.com/haevg-rz/MentorSpeedDatingApp/blob/c712e37f15b81c3c906d015936cbc91de5bb49c0/MentorSpeedDatingApp/ViewModel/MainViewModel.cs#L223
[x] Why JsonConvert.DeserializeAnonymousType? https://github.com/haevg-rz/MentorSpeedDatingApp/blob/c712e37f15b81c3c906d015936cbc91de5bb49c0/MentorSpeedDatingApp/ViewModel/MainViewModel.cs#L245
[ ] TimeSlotCalculator must be under test coverage

remarks

Git Feature Branch Workflow anwende, also je Feature ein Branch
No CD
No CanExecutes

enricopau commented 4 years ago

Why JsonConvert.DeserializeAnonymousType?

"definition" ist ein anonymous type

enricopau commented 4 years ago

How should this work in production?

Saves to and loads from AppData/Local/MSDAPP/savedData.json in Production