search

haf / Castle.Facilities.NHibernate

The NHibernate Facility supercedes NHibernateIntegration and integrates with the new Transaction support. Please read http://stackoverflow.com/questions/4010265/how-to-let-nhibernate-retry-deadlocked-transactions-when-using-session-per-reque before using, it will help you.
https://github.com/haf/Castle.Facilities.NHibernate/wiki
Apache License 2.0
15 stars 23 forks source link

Publish NuGet version with FluentNHibernate 2.0-alpha and NHibernate 4.0 #22

Closed tomasaschan closed 9 years ago

tomasaschan commented 10 years ago

In the process of updating our project (NCVIB :smirk:) to NHibernate 4.0, we needed to update this as well, since it depends on the older versions. After some struggling with rake building (see #21) I managed to build this project in Visual Studio, and the only thing I had to do to make the main project build with the new NHibernate libraries was to go to the package manager console and say

PM> Update-Package NHibernate
PM> Update-Package FluentNHibernate -Pre

Tests didn't compile after that, because the classes C1 et al don't implement all members of INHibernateInstaller (don't know how that worked before...) but other than that everything seems fine. If I just add the missing methods and leave them empty, all tests pass. And if I replace the dlls in our project by the one produced by this VS build, our project also compiles again (except for similar missing methods on `INHibernateInstaller´ implementations).

Would you mind doing the corresponding NuGet updates and publish a version that supports the updated NHibernate libraries? Also, is there any need to add non-empty implementations for the new methods if we don't want any change in behavior?

haf commented 10 years ago

If you send a PR with that, I'll merge it.

If you do the work to make it build nugets nicely, I'll release it. =)

I'm not using this code that much any more, so it's up to the other guys using this code (a fair number of folks it seems) to judge your PRs and the effects they have.

tomasaschan commented 10 years ago

This would have been a PR, had I been able to get it to work locally. The thing is, I can't even get through the rake build process on my machine:

D:\Nitro Consult\Castle.Facilities.NHibernate [master +0 ~14 -0]> rake
Assembly Version: 0.7.1.26814.
##teamcity[buildNumber '0.7.1.26814']
Framework: net40
I, [2014-09-25T14:45:38.315291 #2660]  INFO -- : Generating AssemblyInfo file: D:/Nitro Consult/Castle.Facilities.NHibernate/src/CommonAssemblyInfo.cs
Building config NET40-Release with MsBuild
Microsoft (R) Build Engine version 4.0.30319.33440
[Microsoft .NET Framework, version 4.0.30319.34014]
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 9/25/2014 2:45:38 PM.
Project "D:\Nitro Consult\Castle.Facilities.NHibernate\build.proj" on node 1 (Clean;Build target(s)).
D:\Nitro Consult\Castle.Facilities.NHibernate\build.proj : error MSB4057: The target "Clean;Build" does not exist in the project.
Done Building Project "D:\Nitro Consult\Castle.Facilities.NHibernate\build.proj" (Clean;Build target(s)) -- FAILED.

Build FAILED.

"D:\Nitro Consult\Castle.Facilities.NHibernate\build.proj" (Clean;Build target) (1) ->
  D:\Nitro Consult\Castle.Facilities.NHibernate\build.proj : error MSB4057: The target "Clean;Build" does not exist in the project.

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.03
F, [2014-09-25T14:45:38.488083 #2660] FATAL -- : MSBuild failed, see the build log for more details.
rake aborted!
MSBuild failed, see the build log for more details.

Tasks: TOP => default => release => castle:build => castle:msbuild
(See full trace by running task with --trace)

Since I know next to nothing about rake and ruby, my understanding of the build scripts is very limited and it's quite beyond me to dig into why this fails, or how to fix it.

haf commented 10 years ago

That's not an albacore error, it's an error on your computer for MsBuild.

Run the same msbuild call on your machine to get the same error.

FYI that error is because a MsBuild .target file can't be found or doesn't work in your installation with this project.

Henrik

On 25 Sep 2014, at 14:51, Tomas Lycken notifications@github.com wrote:

Encrypted PGP part This would have been a PR, had I been able to get it to work locally. The thing is, I can't even get through the rake build process on my machine:

D:\Nitro Consult\Castle.Facilities.NHibernate [master +0 ~14 -0]> rake
Assembly Version: 0.7.1.26814.
##teamcity[buildNumber '0.7.1.26814']
Framework: net40
I, [2014-09-25T14:45:38.315291 #2660]  INFO -- : Generating AssemblyInfo file: D:/Nitro Consult/Castle.Facilities.NHibernate/src/CommonAssemblyInfo.cs
Building config NET40-Release with MsBuild
Microsoft (R) Build Engine version 4.0.30319.33440
[Microsoft .NET Framework, version 4.0.30319.34014]
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 9/25/2014 2:45:38 PM.
Project "D:\Nitro Consult\Castle.Facilities.NHibernate\build.proj" on node 1 (Clean;Build target(s)).
D:\Nitro Consult\Castle.Facilities.NHibernate\build.proj : error MSB4057: The target "Clean;Build" does not exist in the project.
Done Building Project "D:\Nitro Consult\Castle.Facilities.NHibernate\build.proj" (Clean;Build target(s)) -- FAILED.

Build FAILED.

"D:\Nitro Consult\Castle.Facilities.NHibernate\build.proj" (Clean;Build target) (1) ->
  D:\Nitro Consult\Castle.Facilities.NHibernate\build.proj : error MSB4057: The target "Clean;Build" does not exist in the project.

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.03
F, [2014-09-25T14:45:38.488083 #2660] FATAL -- : MSBuild failed, see the build log for more details.
rake aborted!
MSBuild failed, see the build log for more details.

Tasks: TOP => default => release => castle:build => castle:msbuild
(See full trace by running task with --trace)

Since I know next to nothing about rake and ruby, my understanding of the build scripts is very limited and it's quite beyond me to dig into why this fails, or how to fix it.

Reply to this email directly or view it on GitHub: https://github.com/haf/Castle.Facilities.NHibernate/issues/22#issuecomment-56813752

tomasaschan commented 10 years ago

Sure it's an msbuild error - but it's not a problem with the msbuild instance on my machine. I can build the project from inside Visual Studio just fine, as soon as I managed to get rake to create the *AssemblyInfo.cs files.

haf commented 10 years ago

If you say so.

If you try to upgrade albacore you'll get a nicer output with the precise msbuild command, and I can assist you in debugging it in the PR that you start. I would definitely appreciate help maintaining this library, like you're doing now.

tomasaschan commented 10 years ago

What version of albacore can I use? If I install any 2.x version, the build fails because albacore/albacoretasks doesn't exist, and if I specify gem install albacore -v "< 2.0.0" (which I thought would give me the latest 1.x release) I get albacore 1.0.0, i.e. the version I used above...

I'll gladly help if I can, but I'm out on deep water here - don't expect miracles ;) But tell me to run any command, and I'll run it and show you the output (well, almost any command...)

haf commented 10 years ago

If you try to copy and paste this https://github.com/albacore/albacore/#creating-your-first-rakefile I can help you from there. I have also written loads for docs https://github.com/albacore/albacore/wiki

Oberheim commented 9 years ago

I am in the process of upgrading a solution to use FluentNHibernate 2.0.1.0 and NHibernate 4.0 as well and am stuck at the same compile error as tlycken and I am guessing that you guys made no progress past that.

haf commented 9 years ago

The reason is the build files. Just create a new C# project in visual studio, replacing the old project files, and add the .cs files to the new C# project. Easy as pie. PR. Merge, release.