search

haf / Castle.Facilities.NHibernate

The NHibernate Facility supercedes NHibernateIntegration and integrates with the new Transaction support. Please read http://stackoverflow.com/questions/4010265/how-to-let-nhibernate-retry-deadlocked-transactions-when-using-session-per-reque before using, it will help you.
https://github.com/haf/Castle.Facilities.NHibernate/wiki
Apache License 2.0
15 stars 23 forks source link

Caching NHibernate configuration #8

Closed flcdrg closed 10 years ago

flcdrg commented 12 years ago

Provide a hook to support serializing the configuration to a file. Default implementation is to serialize/deserialize to a file.

Hopefully whitespace/line ending issues are sorted now.

haf commented 12 years ago

The whitespacing issues are sorted now, but where are the tests?

flcdrg commented 12 years ago

Good point. I'll address your comments and add some tests in too.

Regarding the ILogger.DebugFormat - I've been using those out of habit since the change in Castle 3.0, but I'll switch them back.

On 5 September 2012 01:52, Henrik Feldt notifications@github.com wrote:

The whitespacing issues are sorted now, but where are the tests?

— Reply to this email directly or view it on GitHubhttps://github.com/haf/Castle.Facilities.NHibernate/pull/8#issuecomment-8269253.

flcdrg commented 12 years ago

Ok, I think that's a bit better

haf commented 12 years ago

Alright, nice!

I'm gonna get my .Net development environment up the next couple of days, most likely monday, and then I'll merge and poke some at your tests and code.

haf commented 12 years ago

Btw, a thought slowly forming in my mind is, that this API would be nicer:

container.AddFacility<NHibernateFacility>(f => f.UsePersistentConfig())

What do you think?

flcdrg commented 12 years ago

Yeah, that looks nice.

No worries if you want to rename anything either - I'm just keen to get the functionality included (what ever it ends up being called!)

haf commented 10 years ago

Hi, could you rebase?

flcdrg commented 10 years ago

Hi Henrik! Sure.. will get back to you shortly!

-david

haf commented 10 years ago

Beware that you will have to think about the rebase... That's why I haven't been able to merge this PR yet.

flcdrg commented 10 years ago

Closing this.. redoing pull request