search

haf / DotNetZip.Semverd

Please use System.IO.Compression! A fork of the DotNetZip project without signing with a solution that compiles cleanly. This project aims to follow semver to avoid versioning conflicts. DotNetZip is a FAST, FREE class library and toolset for manipulating zip files. Use VB, C# or any .NET language to easily create, extract, or update zip files.
Other
545 stars 218 forks source link

create nuget with multi-target using dotnet cli #246

Closed svetovid closed 2 years ago

svetovid commented 2 years ago

This is a try to fix strict dependency on System.Security.Permissions 5.0 and System.Text.Encoding.CodePages 5.0 (https://github.com/haf/DotNetZip.Semverd/issues/245), yet to modernize a bit this solution, using dotnet 6.0 cli for nuget package creation.

It's been tested (at least the part that we use in our project) on a .net 6 project.

If this approach happens to be acceptable, then probably Zip NetStandard.csproj and Zip DLL.csproj can be merged with this new Zip DotNet.csproj

JensNordenbro commented 2 years ago

@haf would it be possible to mainline this ?

lahma commented 2 years ago

I did an alternative approach that gives a green build too https://github.com/haf/DotNetZip.Semverd/pull/247 .

haf commented 2 years ago

@JensNordenbro Sorry, I don't merge broken builds. Please resubmit a working build.

JollyKrampus commented 2 years ago

Thank you for adding this! This saved me a bunch of headache