haf / DotNetZip.Semverd

Please use System.IO.Compression! A fork of the DotNetZip project without signing with a solution that compiles cleanly. This project aims to follow semver to avoid versioning conflicts. DotNetZip is a FAST, FREE class library and toolset for manipulating zip files. Use VB, C# or any .NET language to easily create, extract, or update zip files.
Other
545 stars 218 forks source link

License information inside nuget metadata #279

Closed LiorBanai closed 1 year ago

LiorBanai commented 1 year ago

Hi. I'm using autot generated tools like (https://github.com/tomchavakis/nuget-license) to create report of OSS usage. It seem the library is missing the information inside of it . here is example report: image

also in the repo itslef it seems it is not well cleared: image

can this be fixed?

Some option, I think, is to add to the csproj some attributes like:

    <PropertyGroup>
        <PublishRepositoryUrl>true</PublishRepositoryUrl>
        <IncludeSymbols>true</IncludeSymbols>
        <SymbolPackageFormat>snupkg</SymbolPackageFormat>
        <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
        <PackageLicenseExpression>MIT</PackageLicenseExpression>
        <RepositoryType>git</RepositoryType>
        <Nullable>enable</Nullable>
        <LangVersion>latest</LangVersion>
    </PropertyGroup>

the <PackageLicenseExpression>MIT</PackageLicenseExpression> could be relevant (with the correct license of course)

jshergal commented 1 year ago

Related to #28 The library has different pieces that are under different licenses: MS-PL, BSD, MIT, etc. Also, the nuget packages are being built through via execution of a ruby makefile and so there isn't package information included in the csproj files. I don't think there is anyway to address this issue given the current state of the build process and library.