search

haf / Http.fs

A simple, functional HTTP client library for F#
322 stars 43 forks source link

Added RequestHeader.ContentEncoding #164

Closed HoraceGonzalez closed 4 years ago

HoraceGonzalez commented 4 years ago

Added a new ContentEncoding header to the RequestHeader DU. See here for context: https://github.com/haf/Http.fs/issues/163

One of the unfortunate consequences of this change is that the new RequestHeader.ContentEncoding name conflicts with the existing ResponseHeader.ContentEncoding. So, some people may see some compile errors after upgrading along the lines of Expected ResponseHeader.ContentEncoding. Got RequestHeader.ContentEncoding if the values are not fully qualified :]

HoraceGonzalez commented 4 years ago

The Pack target fails on my machine, too. Not sure why.

HoraceGonzalez commented 4 years ago

upgrading paket to 5.219.0 seems to have fixed the issue

haf commented 4 years ago

@HoraceGonzalez If possible, do you think you commit a version 5.219.0 and script to use it? I've upgraded Expecto and Logary for this issue, but haven't gotten around to this repo yet, so perhaps you could do it for me?

HoraceGonzalez commented 4 years ago

No problemo.

HoraceGonzalez commented 4 years ago

@haf, I upgraded the .paket/paket.exe binary, which fixed the build. There didn't appear to be any need to update any scripts. I apologize if this isn't what you had in mind.

I think "upgrading" paket and fake to their respective CLI tool versions might be a task for another PR.

haf commented 4 years ago

Thank you @HoraceGonzalez

HoraceGonzalez commented 4 years ago

@haf, I don't suppose you'd be willing to cut a release to get this change published?

haf commented 4 years ago

Sure, but perhaps we can add a key to Travis to automate this?

On Saturday, Feb 15, 2020 at 1:20 AM, HoraceGonzalez <notifications@github.com (mailto:notifications@github.com)> wrote:

@haf (https://github.com/haf), I don't suppose you'd be willing to cut a release to get this change published?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/haf/Http.fs/pull/164?email_source=notifications&email_token=AABPEW6DW4BCRFQHR4RDWGTRC4YOHA5CNFSM4IYR4WW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL23WBY#issuecomment-586529543), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AABPEWZJHPFLUZTI2TLQWO3RC4YOHANCNFSM4IYR4WWQ).

HoraceGonzalez commented 4 years ago

Sure thing. I'll give it a shot!