haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!
Apache License 2.0
668 stars 96 forks source link

Restore errors #218

Closed forki closed 6 years ago

forki commented 6 years ago

@AnthonyLloyd I change paket to allow nuget exe to do further downloads, but still it's not working on that environment. Can you try to use the https://github.com/SAFE-Stack/SAFE-BookStore/blob/master/appveyor.yml

AnthonyLloyd commented 6 years ago

Thanks for your efforts. What do you want me to do? Copy part of the appveyor.yml config?

forki commented 6 years ago

Yes. Everything is working locally for me. And bookstore is using expecto. So I assume it should work on their appveyor settings

Am 12.01.2018 15:58 schrieb "Anthony Lloyd" notifications@github.com:

Thanks for your efforts. What do you want me to do? Copy part of the appveyor.yml config?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/haf/expecto/pull/218#issuecomment-357260054, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNFqf6dx2txTB0oc3_zkGkaCmi-kCks5tJ3MRgaJpZM4RcK8w .

AnthonyLloyd commented 6 years ago

I tried the appveyor.yml setting without success. I also tried changing the dep file to take out BenchmarkDotNet and do Expecto.BenchmarkDotNet separately. I then deleted paket.lock and regenerated. I've tried updating dotnet core in travis.yml also.

I'm getting different dependency errors now: https://travis-ci.org/haf/expecto/jobs/329256717

Its like the paket.lock generated isn't valid for travis & appveyor. Appveyor is a bit behind on its dotnet core SDK versions but travis is up to date.

forki commented 6 years ago

can you please apply my changes from the build.fsx here? they force install of matching dotnet sdk/cli

AnthonyLloyd commented 6 years ago

Sure thanks, will give it a go later today.

AnthonyLloyd commented 6 years ago

I did this and still have errors. I also tried having only one paket group because it seemed to be downgrading System.Xml.XDocument for some reason.

It works on my machine and travis OSX but not travis Linux or appveyor Windows. Seriously weird.

OSX: https://travis-ci.org/haf/expecto/jobs/329855575

Linux: https://travis-ci.org/haf/expecto/jobs/329855572

/home/travis/build/haf/expecto/Expecto/Expecto.fsproj : warning NU1605:  Expecto -> Argu 3.7.0 -> NETStandard.Library 1.6.1 -> System.Xml.XDocument (>= 4.3.0)  [/home/travis/build/haf/expecto/Expecto.Tests.CSharp/Expecto.Tests.CSharp.csproj]
/home/travis/build/haf/expecto/Expecto/Expecto.fsproj : warning NU1605:  Expecto -> Argu 3.7.0 -> System.Xml.XDocument (>= 4.0.11) [/home/travis/build/haf/expecto/Expecto.Tests.CSharp/Expecto.Tests.CSharp.csproj]
/home/travis/build/haf/expecto/Expecto.Tests.CSharp/Expecto.Tests.CSharp.csproj : error NU1605: Detected package downgrade: System.Xml.XDocument from 4.3.0 to 4.0.11. Reference the package directly from the project to select a different version. 

Windows: https://ci.appveyor.com/project/haf/expecto/build/4.0.544/job/01ip0a44jg2lh1ed

C:\projects\expecto\Expecto.Tests\Expecto.Tests.fsproj : error NU1101: Unable to find package runtime.win7-x86.Microsoft.NETCore.DotNetHostPolicy. No packages exist with this id in source(s): C:\Program Files\dotnet\sdk\NuGetFallbackFolder
forki commented 6 years ago

@AnthonyLloyd I added a workaround to Paket and cleanup this PR. Please review

forki commented 6 years ago

this is green

AnthonyLloyd commented 6 years ago

:) Cool many thanks for all this.

I have one last question (it seems you are my new mentor!). I've been using dotnet pack when the references were in the project files. If I move to paket pack is there an easy way to not have to manually create the template files? I could write a template template and I guess all the dependencies will be resolved without having to put them in the files?

forki commented 6 years ago

what's the motivation to move?

AnthonyLloyd commented 6 years ago

I'm assuming that now the references are not in the project dotnet pack won't be able to include them properly. Does paket step in?

forki commented 6 years ago

yes. paket adds them automatically

AnthonyLloyd commented 6 years ago

Great, many thanks.