search

haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!
Apache License 2.0
668 stars 96 forks source link

Running multiple benchmarks hangs #246

Open haf opened 6 years ago

haf commented 6 years ago

See https://github.com/dotnet/BenchmarkDotNet/issues/755 for details

Not sure on if this is in Expecto or in BenchmarkDotnet.

AnthonyLloyd commented 6 years ago

Yes I guess this is not supported by BenchmarkDotNet.

Easiest global fix Expecto side is to lock the running of this. I can add this.

https://github.com/haf/expecto/blob/04f12c07e7d148c8a7204e7bc6badc73648c5f46/Expecto.BenchmarkDotNet/Expecto.BenchmarkDotNet.fs#L93

Workaround is to testSequenced these benchmarks.

haf commented 6 years ago

I don't think so; if you look towards the end of Program.fs you can see I'm running it sequenced already.

AnthonyLloyd commented 6 years ago

Then I guess its an issue with BenchmarkDotNet. As long as we are really running sequenced and are cleaning up ok.