search

haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!
Apache License 2.0
663 stars 96 forks source link

Test.run returns 1 when all enabled tests pass, but pending tests present #264

Closed jackfoxy closed 6 years ago

jackfoxy commented 6 years ago

Would you consider a different return integer for the use case of all enabled tests passing, but some tests ignored (marked pending)?

AnthonyLloyd commented 6 years ago

As far as can see it only returns 1 if 1) a test fails 2) fail on focus or 3) duplicate test names? Do you see this with pending?

https://github.com/haf/expecto/blob/b81d5be1eeb1f7d02b03ebd4b8ee24ea58a17e12/Expecto/Expecto.fs#L1700

jackfoxy commented 6 years ago

My mistake. Investigated again and you are correct.